Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 537663002: HPACK: encode :pseudo and indexed headers first. (Closed)

Created:
6 years, 3 months ago by Bence
Modified:
6 years, 3 months ago
Reviewers:
Johnny
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

HPACK: encode :pseudo and indexed headers first. HTTP/2 header compression HPACK draft-09 requires pseudo-headers (names starting with ":") to be encoded before regular headers. Also, headers that are in the header table are emitted before others, to avoid eviction before they could be used. This lands server change 74039742 by bnc. BUG=395635 Committed: https://crrev.com/fb8795450e61e29750975a07a956be75b38a2fcd Cr-Commit-Position: refs/heads/master@{#293290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -26 lines) Patch
M net/spdy/hpack_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/spdy/hpack_encoder.cc View 2 chunks +46 lines, -14 lines 0 comments Download
M net/spdy/hpack_encoder_test.cc View 2 chunks +35 lines, -10 lines 0 comments Download
M net/spdy/hpack_output_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_round_trip_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Bence
PTAL
6 years, 3 months ago (2014-09-03 19:54:09 UTC) #2
Johnny
lgtm
6 years, 3 months ago (2014-09-03 21:28:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/537663002/1
6 years, 3 months ago (2014-09-04 00:41:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1932)
6 years, 3 months ago (2014-09-04 02:56:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/537663002/1
6 years, 3 months ago (2014-09-04 12:37:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4e2559eb73fcf0f8de6a004cb2771fdc2de5adbf
6 years, 3 months ago (2014-09-04 13:09:07 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb8795450e61e29750975a07a956be75b38a2fcd
Cr-Commit-Position: refs/heads/master@{#293290}

Powered by Google App Engine
This is Rietveld 408576698