net/spdy/hpack_output_stream.cc - Issue 537663002: HPACK: encode :pseudo and indexed headers first.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/hpack_output_stream.cc

Issue 537663002: HPACK: encode :pseudo and indexed headers first. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/hpack_output_stream.cc

diff --git a/net/spdy/hpack_output_stream.cc b/net/spdy/hpack_output_stream.cc

index 20f901d3b398c7f3f7df071daa101eb6f62410bb..d8eb54bb839b91dbca37d7ffc16213916a306634 100644

--- a/net/spdy/hpack_output_stream.cc

+++ b/net/spdy/hpack_output_stream.cc

@@ -49,7 +49,7 @@ void HpackOutputStream::AppendBytes(StringPiece buffer) {

}

void HpackOutputStream::AppendUint32(uint32 I) {

- // The algorithm below is adapted from the pseudocode in 4.1.1.

+ // The algorithm below is adapted from the pseudocode in 6.1.

size_t N = 8 - bit_offset_;

uint8 max_first_byte = static_cast<uint8>((1 << N) - 1);

if (I < max_first_byte) {

« no previous file with comments | « net/spdy/hpack_encoder_test.cc ('k') | net/spdy/hpack_round_trip_test.cc » ('j') | no next file with comments »