Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 537633002: Allow for Skia to be built without dwrite 1.1 (Closed)

Created:
6 years, 3 months ago by gw280
Modified:
6 years, 3 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Allow for Skia to be built without dwrite 1.1 We still have developers on XP and Vista, so we would like to be able to add an SK_IGNORE_DWRITE_1_SUPPORT flag in the same style as SK_IGNORE_ETC1_SUPPORT. It looks like the code is already set up to fallback at runtime anyway, this just enforces that fallback at compile time. Patch originally from https://bugzilla.mozilla.org/show_bug.cgi?id=1053652 R=bungeman BUG=skia:

Patch Set 1 #

Patch Set 2 : And those should be ifndef not ifdef... #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/ports/SkScalerContext_win_dw.cpp View 1 3 chunks +6 lines, -1 line 0 comments Download
M src/ports/SkTypeface_win_dw.h View 1 3 chunks +6 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
gw280
6 years, 3 months ago (2014-09-03 17:16:36 UTC) #1
bungeman-skia
https://codereview.chromium.org/537633002/diff/20001/src/ports/SkTypeface_win_dw.h File src/ports/SkTypeface_win_dw.h (right): https://codereview.chromium.org/537633002/diff/20001/src/ports/SkTypeface_win_dw.h#newcode20 src/ports/SkTypeface_win_dw.h:20: #ifndef SK_IGNORE_DWRITE_1_SUPPORT Ick, I'm against adding yet another magic ...
6 years, 3 months ago (2014-09-08 21:10:04 UTC) #3
gw280
On 2014/09/08 21:10:04, bungeman1 wrote: > It looks like we could use winsdkver.h, (the casing ...
6 years, 3 months ago (2014-09-09 06:22:44 UTC) #4
bungeman-skia
On 2014/09/09 06:22:44, gw280 wrote: > On 2014/09/08 21:10:04, bungeman1 wrote: > > It looks ...
6 years, 3 months ago (2014-09-09 15:19:36 UTC) #5
bungeman-skia
6 years, 3 months ago (2014-09-10 19:17:06 UTC) #6
Message was sent while issue was closed.
On 2014/09/09 15:19:36, bungeman1 wrote:
> On 2014/09/09 06:22:44, gw280 wrote:
> > On 2014/09/08 21:10:04, bungeman1 wrote:
> > > It looks like we could use winsdkver.h, (the casing of which changed from
> > > WinSDKVer.h to winsdkver.h in SDK 7.1A) but avoid the madness that is
> > > NTDDI_MAXVER which seems to be set to something semi-random with each SDK
> > update
> > > (it only actually matches the max supported NTDDI_VER in SDK7.1). As a
> result,
> > > it seems like the easiest correct-ish thing to do here is put something
like
> > > 
> > > #define SK_HAS_DWRITE_1 (WINVER_MAXVER >= 0x0602)
> > > 
> > > in SkDWrite.h and then use it like
> > > 
> > > #if SK_HAS_DWRITE_1 
> > > 
> > > in places like this. It would also be nice to #warn that you're building
> with
> > > reduced functionality if you don't have the requisite support in your SDK.
> > Note
> > > that sometime soon-ish we will also end up doing something like this for
> color
> > > support, since that requires dwrite_2.h.
> > 
> > That looks reasonable. I will sort that out tomorrow, thanks for the hints.
> 
> I happen to have an XP vm sitting around, so I took a look into this.
> See https://codereview.chromium.org/552383002/ .

I'm closing this issue since https://codereview.chromium.org/552383002/ has
landed. If there are still issues, please let us know.

Powered by Google App Engine
This is Rietveld 408576698