components/cronet/android/java/src/org/chromium/net/Version.template - Issue 537573004: Cronet version now uses first 8 characters of LASTCHANGE string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/Version.template

Issue 537573004: Cronet version now uses first 8 characters of LASTCHANGE string. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/HttpUrlRequestFactoryTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/Version.template

diff --git a/components/cronet/android/java/src/org/chromium/net/Version.template b/components/cronet/android/java/src/org/chromium/net/Version.template

index 0bf32dbdf30ed05ba53ef600d65276e2b65c5373..552b6d597606f5261469e53d3f2dd57b98ca8d22 100644

--- a/components/cronet/android/java/src/org/chromium/net/Version.template

+++ b/components/cronet/android/java/src/org/chromium/net/Version.template

@@ -10,6 +10,6 @@ public class Version {

public static final String LAST_CHANGE = "@LASTCHANGE@";

public static String getVersion() {

- return CRONET_VERSION + "@" + LAST_CHANGE;

+ return CRONET_VERSION + "@" + LAST_CHANGE.substring(1, 8);

mmenke 2014/09/03 18:17:39 Shouldn't this be substring(0, 8)?

mef 2014/09/03 18:36:15 Oops. Done.

}