components/cronet/android/java/src/org/chromium/net/Version.template - Issue 537573004: Cronet version now uses first 8 characters of LASTCHANGE string.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/cronet/android/java/src/org/chromium/net/Version.template

Issue 537573004: Cronet version now uses first 8 characters of LASTCHANGE string. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/HttpUrlRequestFactoryTest.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.net;	5 package org.chromium.net;

6	6

7 // Version based on chrome/VERSION.	7 // Version based on chrome/VERSION.

8 public class Version {	8 public class Version {

9 public static final String CRONET_VERSION = "@MAJOR@.@MINOR@.@BUILD@.@PATCH@ ";	9 public static final String CRONET_VERSION = "@MAJOR@.@MINOR@.@BUILD@.@PATCH@ ";

10 public static final String LAST_CHANGE = "@LASTCHANGE@";	10 public static final String LAST_CHANGE = "@LASTCHANGE@";

11	11

12 public static String getVersion() {	12 public static String getVersion() {

13 return CRONET_VERSION + "@" + LAST_CHANGE;	13 return CRONET_VERSION + "@" + LAST_CHANGE.substring(1, 8);
	mmenke 2014/09/03 18:17:39 Shouldn't this be substring(0, 8)? Shouldn't this be substring(0, 8)? mef 2014/09/03 18:36:15 Oops. Done. Show quoted text On 2014/09/03 18:17:39, mmenke wrote: > Shouldn't this be substring(0, 8)? Oops. Done.
14 }	14 }

15 }	15 }

OLD	NEW