Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 537573004: Cronet version now uses first 8 characters of LASTCHANGE string. (Closed)

Created:
6 years, 3 months ago by mef
Modified:
6 years, 3 months ago
Reviewers:
mmenke, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cronet version now uses first 8 characters of LASTCHANGE string. BUG= Committed: https://crrev.com/b0b78ba71bceb23997eec65d2fb878ca48ed507b Cr-Commit-Position: refs/heads/master@{#293210}

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : Fix substring index. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M components/cronet/android/java/src/org/chromium/net/Version.template View 1 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/HttpUrlRequestFactoryTest.java View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mef
6 years, 3 months ago (2014-09-03 18:12:54 UTC) #3
mmenke
https://codereview.chromium.org/537573004/diff/20001/components/cronet/android/java/src/org/chromium/net/Version.template File components/cronet/android/java/src/org/chromium/net/Version.template (right): https://codereview.chromium.org/537573004/diff/20001/components/cronet/android/java/src/org/chromium/net/Version.template#newcode13 components/cronet/android/java/src/org/chromium/net/Version.template:13: return CRONET_VERSION + "@" + LAST_CHANGE.substring(1, 8); Shouldn't this ...
6 years, 3 months ago (2014-09-03 18:17:39 UTC) #4
mef
https://codereview.chromium.org/537573004/diff/20001/components/cronet/android/java/src/org/chromium/net/Version.template File components/cronet/android/java/src/org/chromium/net/Version.template (right): https://codereview.chromium.org/537573004/diff/20001/components/cronet/android/java/src/org/chromium/net/Version.template#newcode13 components/cronet/android/java/src/org/chromium/net/Version.template:13: return CRONET_VERSION + "@" + LAST_CHANGE.substring(1, 8); On 2014/09/03 ...
6 years, 3 months ago (2014-09-03 18:36:16 UTC) #5
mmenke
On 2014/09/03 18:36:16, mef wrote: > https://codereview.chromium.org/537573004/diff/20001/components/cronet/android/java/src/org/chromium/net/Version.template > File components/cronet/android/java/src/org/chromium/net/Version.template > (right): > > https://codereview.chromium.org/537573004/diff/20001/components/cronet/android/java/src/org/chromium/net/Version.template#newcode13 ...
6 years, 3 months ago (2014-09-03 18:46:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/537573004/40001
6 years, 3 months ago (2014-09-03 18:48:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001) as c4dcbf741c93d62b828541ea04522c8d689951df
6 years, 3 months ago (2014-09-03 23:13:04 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:28:12 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b0b78ba71bceb23997eec65d2fb878ca48ed507b
Cr-Commit-Position: refs/heads/master@{#293210}

Powered by Google App Engine
This is Rietveld 408576698