Issue 537543002: Don't create a v8 isolate in ppapi tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 537543002: Don't create a v8 isolate in ppapi tests (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 3 months ago

Reviewers:
dmichael (off chromium), Andrew Hayden (chromium.org)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Don't create a v8 isolate in ppapi tests The unit test framework brings up blink, so we have an initialized isolate we can just use. BUG=none R=andrewhayden@chromium.org,dmichael@chromium.org Committed: https://crrev.com/0895d8016aec431402c5fabad4e7927cdaf4807f Cr-Commit-Position: refs/heads/master@{#293133}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	content/renderer/pepper/npapi_glue.cc	View		1 chunk	+3 lines, -8 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/537543002/1

6 years, 3 months ago (2014-09-03 13:23:13 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 03cf6e00ed244b75c96e627c225211a76673bef7

6 years, 3 months ago (2014-09-03 13:57:09 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:25:36 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0895d8016aec431402c5fabad4e7927cdaf4807f
Cr-Commit-Position: refs/heads/master@{#293133}