Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: content/renderer/pepper/npapi_glue.cc

Issue 537543002: Don't create a v8 isolate in ppapi tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/npapi_glue.cc
diff --git a/content/renderer/pepper/npapi_glue.cc b/content/renderer/pepper/npapi_glue.cc
index 990d3302e89f7c7bca1adc0c0ae476eccaa8dd7f..9d73586506408dee8dd3e586dbd1a928a2781f13 100644
--- a/content/renderer/pepper/npapi_glue.cc
+++ b/content/renderer/pepper/npapi_glue.cc
@@ -189,15 +189,10 @@ PP_Var NPObjectToPPVar(PepperPluginInstanceImpl* instance, NPObject* object) {
PP_Var NPObjectToPPVarForTest(PepperPluginInstanceImpl* instance,
NPObject* object) {
- v8::Isolate* test_isolate = v8::Isolate::New();
PP_Var result = PP_MakeUndefined();
- {
- v8::HandleScope scope(test_isolate);
- v8::Isolate::Scope isolate_scope(test_isolate);
- v8::Local<v8::Context> context = v8::Context::New(test_isolate);
- result = NPObjectToPPVarImpl(instance, object, context);
- }
- test_isolate->Dispose();
+ v8::HandleScope scope(instance->GetIsolate());
+ v8::Local<v8::Context> context = v8::Context::New(instance->GetIsolate());
+ result = NPObjectToPPVarImpl(instance, object, context);
return result;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698