LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js - Issue 537103002: Spec compliant url.search/url.hash setters over empty values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js

Issue 537103002: Spec compliant url.search/url.hash setters over empty values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Sync expected output Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js ('k') | LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js

diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js b/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js

index 4799fdc4dbd2782182548fd6204d5fc7d855a676..39370a109a3c4c0130b3c3677d92e8456631d5cf 100644

--- a/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js

+++ b/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js

@@ -38,9 +38,9 @@ a.href = "https://www.mydomain.com/path/?key=value";

a.search = null;

shouldBe("a.href", "'https://www.mydomain.com/path/?null'");

-// Firefox 3.5.2 Removes the '?', and it shouldn't, per

-// http://dev.w3.org/html5/spec/infrastructure.html#url-decomposition-idl-attributes .

+// Firefox 3.5.2 Removes the '?', and it should, per

+// http://url.spec.whatwg.org/#dom-url-search

debug("Set search to empty string");

a.href = "https://www.mydomain.com/path/?key=value";

a.search = "";

-shouldBe("a.href", "'https://www.mydomain.com/path/?'");

+shouldBe("a.href", "'https://www.mydomain.com/path/'");