Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js

Issue 537103002: Spec compliant url.search/url.hash setters over empty values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Sync expected output Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js
diff --git a/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js b/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js
index 66d6c9719906b0ff3cb07d606b507931a85f837c..4cd3ed942b718fa66f451c9f3482431662db98ed 100644
--- a/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js
+++ b/LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js
@@ -30,11 +30,11 @@ a.hash = null;
shouldBe("a.href", "'https://www.mydomain.com/path/testurl.html#null'");
// Firefox 3.5.2 removes the '#' at the end, and it should per
-// http://dev.w3.org/html5/spec/infrastructure.html#url-decomposition-idl-attributes .
+// http://url.spec.whatwg.org/#dom-url-hash
debug("Set hash to empty string");
a.href = "https://www.mydomain.com/path/testurl.html#middle";
a.hash = "";
-shouldBe("a.href", "'https://www.mydomain.com/path/testurl.html#'");
+shouldBe("a.href", "'https://www.mydomain.com/path/testurl.html'");
// Firefox 3.5.2 does not allow setting hash to mailto: scheme, and it should.
debug("Add hash to mailto: protocol");
@@ -52,7 +52,7 @@ shouldBe("a.href", "'file:///some%20path#hash value'");
debug("Set hash to '#'");
a.href = "http://mydomain.com#middle";
a.hash = "#";
-shouldBe("a.href", "'http://mydomain.com/#'");
+shouldBe("a.href", "'http://mydomain.com/'");
// Firefox 3.5.2 does not allow setting hash to foo: scheme, and it should.
debug("Add hash to non-standard protocol");
« no previous file with comments | « no previous file | LayoutTests/fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698