Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: ui/base/ui_base_tests_bundle.gypi

Issue 537063002: Eliminate silently letting errors pass on pak loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one last time Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/base/ui_base_tests.gypi ('K') | « ui/base/ui_base_tests.isolate ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ui_base_tests_bundle.gypi
diff --git a/ui/base/ui_base_tests_bundle.gypi b/ui/base/ui_base_tests_bundle.gypi
index 8fb6307339560bfff7be281243cf8c7622245812..ba2e8f6a5703268076ee22301a734a6da46a8df0 100644
--- a/ui/base/ui_base_tests_bundle.gypi
+++ b/ui/base/ui_base_tests_bundle.gypi
@@ -40,9 +40,9 @@
'${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}/Resources'
],
},
+ # The Mac resource bundle code hard-codes the names of the 100% and 200%
+ # paks. This symlinking allows ui_test.pak to stand in for them.
{
- # Resource bundle pak names are hardcoded. This allows ui_test.pak to be
- # found while running the ResourceBundle tests.
'postbuild_name': 'Symlink chrome_100_percent for test',
'action': [
'ln',
@@ -51,5 +51,14 @@
'${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}/Versions/A/Resources/chrome_100_percent.pak'
],
},
+ {
+ 'postbuild_name': 'Symlink chrome_200_percent for test',
+ 'action': [
+ 'ln',
+ '-fns',
+ 'ui_test.pak',
+ '${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}/Versions/A/Resources/chrome_200_percent.pak'
+ ],
+ },
],
}
« ui/base/ui_base_tests.gypi ('K') | « ui/base/ui_base_tests.isolate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698