Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: ui/base/ui_base_tests.gypi

Issue 537063002: Eliminate silently letting errors pass on pak loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one last time Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ui_base_paths.cc ('k') | ui/base/ui_base_tests.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ui_base_tests.gypi
diff --git a/ui/base/ui_base_tests.gypi b/ui/base/ui_base_tests.gypi
index 44a251a14900b2aa68d88e491f53e4f7e56cd5ee..d0b9fbcc6cc0ec16f9c09fe3014e7251c5f06e6d 100644
--- a/ui/base/ui_base_tests.gypi
+++ b/ui/base/ui_base_tests.gypi
@@ -100,6 +100,26 @@
'includes': [ '../../build/copy_test_data_ios.gypi' ],
},
],
+ 'postbuilds': [
+ # The iOS resource bundle code hard-codes the names of the 100% and
+ # 200% paks. This copying allows locale.pak to stand in for them.
+ {
+ 'postbuild_name': 'Copy chrome_100_percent for test',
+ 'action': [
+ 'cp',
tony 2014/10/15 17:35:21 I thought there was a 'copies' command that gyp kn
Avi (use Gerrit) 2014/10/15 17:39:59 I don't know; I don't speak gyp very well. I tried
+ '${BUILT_PRODUCTS_DIR}/ui/en.lproj/locale.pak',
+ '${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}/chrome_100_percent.pak'
+ ],
+ },
+ {
+ 'postbuild_name': 'Copy chrome_200_percent for test',
+ 'action': [
+ 'cp',
+ '${BUILT_PRODUCTS_DIR}/ui/en.lproj/locale.pak',
+ '${BUILT_PRODUCTS_DIR}/${WRAPPER_NAME}/chrome_200_percent.pak'
+ ],
+ },
+ ],
}],
['OS == "win"', {
'sources': [
« no previous file with comments | « ui/base/ui_base_paths.cc ('k') | ui/base/ui_base_tests.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698