ui/base/resource/data_pack_literal.cc - Issue 537063002: Eliminate silently letting errors pass on pak loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/resource/data_pack_literal.cc

Issue 537063002: Eliminate silently letting errors pass on pak loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ios finally works Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/dom_distiller/core/distiller_unittest.cc ('K') | « components/dom_distiller/core/distiller_unittest.cc ('k') | ui/base/resource/resource_bundle.cc » ('j') | ui/base/resource/resource_bundle_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/base/resource/data_pack_literal.cc

diff --git a/ui/base/resource/data_pack_literal.cc b/ui/base/resource/data_pack_literal.cc

index 0b3855f3a99c95f50814458031f6e2e05d53e6d8..672e55257eb4b88c713b99379362048932042ff2 100644

--- a/ui/base/resource/data_pack_literal.cc

+++ b/ui/base/resource/data_pack_literal.cc

@@ -51,7 +51,8 @@ extern const size_t kSamplePakSize2x = sizeof(kSamplePakContents2x);

extern const char kEmptyPakContents[] = {

0x04, 0x00, 0x00, 0x00, // header(version

0x00, 0x00, 0x00, 0x00, // no. entries

- 0x01

+ 0x01, // encoding)

+ 0x00, 0x00, 0x0f, 0x00, 0x00, 0x00 // extra entry for the size of last

};

extern const size_t kEmptyPakSize = sizeof(kEmptyPakContents);