Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: components/dom_distiller/core/distiller_unittest.cc

Issue 537063002: Eliminate silently letting errors pass on pak loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ios finally works Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/resource/data_pack_literal.cc » ('j') | ui/base/resource/resource_bundle_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/core/distiller_unittest.cc
diff --git a/components/dom_distiller/core/distiller_unittest.cc b/components/dom_distiller/core/distiller_unittest.cc
index e57510997c2080216e233f19821c60c0abb2a207..7dafbd4daba6b06f8df20395d4288845b7bbd7ee 100644
--- a/components/dom_distiller/core/distiller_unittest.cc
+++ b/components/dom_distiller/core/distiller_unittest.cc
@@ -26,7 +26,6 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/dom_distiller_js/dom_distiller.pb.h"
#include "third_party/dom_distiller_js/dom_distiller_json_converter.h"
-#include "ui/base/resource/resource_bundle.h"
using std::vector;
using std::string;
@@ -187,15 +186,6 @@ void VerifyArticleProtoMatchesMultipageData(
}
}
-void AddComponentsResources() {
- base::FilePath pak_file;
- base::FilePath pak_dir;
- PathService::Get(base::DIR_MODULE, &pak_dir);
- pak_file = pak_dir.Append(FILE_PATH_LITERAL("components_resources.pak"));
- ui::ResourceBundle::GetSharedInstance().AddDataPackFromPath(
- pak_file, ui::SCALE_FACTOR_NONE);
-}
-
} // namespace
namespace dom_distiller {
@@ -257,10 +247,6 @@ class DistillerTest : public testing::Test {
public:
virtual ~DistillerTest() {}
- virtual void SetUp() OVERRIDE {
- AddComponentsResources();
- }
-
void OnDistillArticleDone(scoped_ptr<DistilledArticleProto> proto) {
article_proto_ = proto.Pass();
}
« no previous file with comments | « no previous file | ui/base/resource/data_pack_literal.cc » ('j') | ui/base/resource/resource_bundle_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698