src/lookup-inl.h - Issue 536943002: Never skip access checks when looking up properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup-inl.h

Issue 536943002: Never skip access checks when looking up properties (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lookup-inl.h

diff --git a/src/lookup-inl.h b/src/lookup-inl.h

index d87221e7c913d60be0ebbc8938e47f13e87482fe..022bf7d07b1619aa8dfefb5af0501bb7d14509ed 100644

--- a/src/lookup-inl.h

+++ b/src/lookup-inl.h

@@ -36,12 +36,8 @@ LookupIterator::State LookupIterator::LookupInHolder(Map* map) {

DisallowHeapAllocation no_gc;

switch (state_) {

case NOT_FOUND:

- if (map->IsJSProxyMap()) {

- return JSPROXY;

- }

- if (check_access_check() && map->is_access_check_needed()) {

- return ACCESS_CHECK;

- }

+ if (map->IsJSProxyMap()) return JSPROXY;

+ if (map->is_access_check_needed()) return ACCESS_CHECK;

// Fall through.

case ACCESS_CHECK:

if (check_interceptor() && map->has_named_interceptor()) {

« no previous file with comments | « src/lookup.h ('k') | src/objects.cc » ('j') | no next file with comments »