Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 536843003: Disable eager gesture detection. (Closed)

Created:
6 years, 3 months ago by tdresser
Modified:
6 years, 3 months ago
CC:
ben+aura_chromium.org, chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable eager gesture detection. While working on a fix to issue 408594, we'll disable eager gesture detection. BUG=408594 Committed: https://crrev.com/041843cbf814dbd52542a985b638d76457290879 Cr-Commit-Position: refs/heads/master@{#293762}

Patch Set 1 #

Patch Set 2 : Disable test depending on eager behavior. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_event_dispatcher.cc View 3 chunks +22 lines, -17 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (10 generated)
tdresser
6 years, 3 months ago (2014-09-03 13:48:47 UTC) #2
sadrul
lgtm
6 years, 3 months ago (2014-09-03 20:23:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/536843003/1
6 years, 3 months ago (2014-09-04 12:12:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/10825)
6 years, 3 months ago (2014-09-04 13:21:55 UTC) #7
tdresser
Jochen, can you take a look at: content/browser/web_contents/web_contents_view_aura_browsertest.cc Disabling this test will be quite temporary ...
6 years, 3 months ago (2014-09-04 15:24:58 UTC) #10
jdduke (slow)
On 2014/09/04 15:24:58, tdresser wrote: > Jochen, can you take a look at: > content/browser/web_contents/web_contents_view_aura_browsertest.cc ...
6 years, 3 months ago (2014-09-04 15:35:53 UTC) #11
tdresser
On 2014/09/04 15:35:53, jdduke wrote: > On 2014/09/04 15:24:58, tdresser wrote: > > Jochen, can ...
6 years, 3 months ago (2014-09-04 15:36:27 UTC) #12
jdduke (slow)
> Does eager GR simply change how the test is implemented? or does the > ...
6 years, 3 months ago (2014-09-04 15:36:45 UTC) #13
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-08 12:41:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/536843003/20001
6 years, 3 months ago (2014-09-08 13:03:34 UTC) #16
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 15:04:43 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/536843003/20001
6 years, 3 months ago (2014-09-08 15:08:21 UTC) #20
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 17:20:20 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/536843003/20001
6 years, 3 months ago (2014-09-08 18:07:35 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7f02aab51238701133ce9a57b7f0e11d4321f481
6 years, 3 months ago (2014-09-08 18:51:06 UTC) #25
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:25 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/041843cbf814dbd52542a985b638d76457290879
Cr-Commit-Position: refs/heads/master@{#293762}

Powered by Google App Engine
This is Rietveld 408576698