Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Unified Diff: Source/platform/audio/mac/FFTFrameMac.cpp

Issue 536843002: Change members's order and combine duplicated method for FFTFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/audio/ipp/FFTFrameIPP.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/audio/mac/FFTFrameMac.cpp
diff --git a/Source/platform/audio/mac/FFTFrameMac.cpp b/Source/platform/audio/mac/FFTFrameMac.cpp
index 718fa14d0882ed6a710dfba46af47b86f6cd603d..cf53ddb1a6b093052b9549bfa92124a6795f026e 100644
--- a/Source/platform/audio/mac/FFTFrameMac.cpp
+++ b/Source/platform/audio/mac/FFTFrameMac.cpp
@@ -80,9 +80,9 @@ FFTFrame::FFTFrame()
FFTFrame::FFTFrame(const FFTFrame& frame)
: m_FFTSize(frame.m_FFTSize)
, m_log2FFTSize(frame.m_log2FFTSize)
- , m_FFTSetup(frame.m_FFTSetup)
, m_realData(frame.m_FFTSize)
, m_imagData(frame.m_FFTSize)
+ , m_FFTSetup(frame.m_FFTSetup)
{
// Setup frame data
m_frame.realp = m_realData.data();
@@ -117,7 +117,7 @@ void FFTFrame::doInverseFFT(float* data)
// Do final scaling so that x == IFFT(FFT(x))
float scale = 1.0f / m_FFTSize;
- vDSP_vsmul(data, 1, &scale, data, 1, m_FFTSize);
+ VectorMath::vsmul(data, 1, &scale, data, 1, m_FFTSize);
Raymond Toy 2014/09/03 16:42:47 This looks wrong. Why the change from vDSP_vsmul
KhNo 2014/09/04 04:11:36 To make it has unity and code maintenance.
Raymond Toy 2014/09/04 17:14:57 I would prefer this change be done separately. Th
}
FFTSetup FFTFrame::fftSetupForSize(unsigned fftSize)
@@ -153,16 +153,6 @@ void FFTFrame::cleanup()
fftSetups = 0;
}
-float* FFTFrame::realData() const
-{
- return m_frame.realp;
KhNo 2014/09/04 04:11:36 .realp and .imap are just pointer of m_realData.da
Raymond Toy 2014/09/04 17:14:57 Oh, because of line 62-63 in FFTFrame::FFTFrame.
-}
-
-float* FFTFrame::imagData() const
-{
- return m_frame.imagp;
-}
-
} // namespace blink
#endif // #if OS(MACOSX)
« no previous file with comments | « Source/platform/audio/ipp/FFTFrameIPP.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698