chrome/browser/ui/webui/options/options_browsertest.js - Issue 536703002: Get rid of some <label for> misuse in browser_options.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/options_browsertest.js

Issue 536703002: Get rid of some <label for> misuse in browser_options.html (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/options_browsertest.js

diff --git a/chrome/browser/ui/webui/options/options_browsertest.js b/chrome/browser/ui/webui/options/options_browsertest.js

index adac5d7b7cb64e2a200d8964cd19367f42e06fe1..3dee876795ba25581b4ba577f18a48a95e609f48 100644

--- a/chrome/browser/ui/webui/options/options_browsertest.js

+++ b/chrome/browser/ui/webui/options/options_browsertest.js

@@ -99,7 +99,8 @@ GEN('#endif // defined(OS_MACOSX)');

TEST_F('OptionsWebUITest', 'MAYBE_testSetBooleanPrefTriggers', function() {

// TODO(dtseng): make generic to click all buttons.

- var showHomeButton = $('show-home-button');

+ var showHomeButton =

+ document.querySelector('input[pref="browser.show_home_button"]');

var trueListValue = [

'browser.show_home_button',

true,

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc ('k') | ui/webui/resources/css/widgets.css » ('j') | no next file with comments »