chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc - Issue 536703002: Get rid of some <label for> misuse in browser_options.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

Issue 536703002: Get rid of some <label for> misuse in browser_options.html (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/controlled_setting.css ('k') | chrome/browser/ui/webui/options/options_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc b/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

index b7dc0ec244616c107c867eea681ab0aff1ed9d05..9a5bb08688f328e2f514989b5d9159c9947826da 100644

--- a/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

+++ b/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

@@ -158,8 +158,8 @@ class SharedOptionsTest : public LoginManagerTest {

"var success = false;"

"if (input) {"

" success = input.disabled == %d;"

- " var indicator = document.querySelector(input.tagName +"

- " prefSelector + ' + span span.controlled-setting-indicator');"

+ " var indicator = input.parentNode.parentNode.querySelector("

+ " '.controlled-setting-indicator');"

" if (controlledBy) {"

" success = success && indicator &&"

" indicator.getAttribute('controlled-by') == controlledBy;"

« no previous file with comments | « chrome/browser/resources/options/controlled_setting.css ('k') | chrome/browser/ui/webui/options/options_browsertest.js » ('j') | no next file with comments »