Add ExtensionManagement based ExternalLoader

chrome/browser/extensions/api/management/management_browsertest.cc

Index: chrome/browser/extensions/api/management/management_browsertest.cc
diff --git a/chrome/browser/extensions/api/management/management_browsertest.cc b/chrome/browser/extensions/api/management/management_browsertest.cc
index 9656e9d3edb9cdf8f63163c2292642aa214a0ead..629f75e42ede0dfc6c9fa140bceefb94864b2c5d 100644
--- a/chrome/browser/extensions/api/management/management_browsertest.cc
+++ b/chrome/browser/extensions/api/management/management_browsertest.cc
@@ -9,6 +9,7 @@
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/stl_util.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
+#include "chrome/browser/extensions/extension_management.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
 #include "chrome/browser/extensions/external_policy_loader.h"
@@ -509,6 +510,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalPolicyRefresh) {
   ASSERT_TRUE(registry->disabled_extensions().is_empty());
 
   PrefService* prefs = browser()->profile()->GetPrefs();
+  extensions::ExtensionManagementFactory::GetForBrowserContext(
+      browser()->profile())->AllowUserPreferenceForTesting();

[Joao da Silva, 2014/09/07 14:30:21]

Don't do this. The right way to mock policies for tests is to use
BrowserPolicyConnector::SetPolicyProviderForTesting. See policy_browsertest.cc
for an example.

[binjin, 2014/09/08 12:59:39]

It's browser tests for extensions system, user preference kInstallForcelist was
used here, I don't think it's easy to integrate PolicyProviders here.

Another options is providing SetForceInstallListForTesting(), what do you think?

[Joao da Silva, 2014/09/08 13:18:29]

This test code needs to be updated, because it was relying on setting that pref
at a user level but it should be set at a mandatory policy level.

The way to do that in a test is with a MockConfigurationPolicyProvider passed to
BrowserPolicyConnector::SetPolicyProviderForTesting, and then you can set any
policies in that mock object. policy_browsertest.cc has example code that you
can just copy and paste here.

Note that this test is testing how the extensions code handles an
ExternalPolicyRefresh, so it's fair to require some setup for the policy parts.

[binjin, 2014/09/08 14:52:05]

Got it. Done.

   const base::DictionaryValue* forcelist =
       prefs->GetDictionary(extensions::pref_names::kInstallForceList);
   ASSERT_TRUE(forcelist->empty()) << kForceInstallNotEmptyHelp;
@@ -583,6 +586,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest,
 
   // Check that the policy is initially empty.
   PrefService* prefs = browser()->profile()->GetPrefs();
+  extensions::ExtensionManagementFactory::GetForBrowserContext(
+      browser()->profile())->AllowUserPreferenceForTesting();
   const base::DictionaryValue* forcelist =
       prefs->GetDictionary(extensions::pref_names::kInstallForceList);
   ASSERT_TRUE(forcelist->empty()) << kForceInstallNotEmptyHelp;