Add ExtensionManagement based ExternalLoader

chrome/browser/extensions/api/management/management_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/ref_counted.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/stl_util.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
+#include "chrome/browser/extensions/extension_management.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
 #include "chrome/browser/extensions/external_policy_loader.h"
 #include "chrome/browser/extensions/updater/extension_downloader.h"
 #include "chrome/browser/extensions/updater/extension_updater.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
@@ skipping 480 matching lines @@
       GURL("http://localhost/autoupdate/manifest"),
       basedir.AppendASCII("manifest_v2.xml"));
   interceptor.SetResponseIgnoreQuery(GURL("http://localhost/autoupdate/v2.crx"),
                                      basedir.AppendASCII("v2.crx"));
 
   ExtensionRegistry* registry = ExtensionRegistry::Get(browser()->profile());
   const size_t size_before = registry->enabled_extensions().size();
   ASSERT_TRUE(registry->disabled_extensions().is_empty());
 
   PrefService* prefs = browser()->profile()->GetPrefs();
+  extensions::ExtensionManagementFactory::GetForBrowserContext(
+      browser()->profile())->AllowUserPreferenceForTesting();

[Joao da Silva, 2014/09/07 14:30:21]

Don't do this. The right way to mock policies for tests is to use
BrowserPolicyConnector::SetPolicyProviderForTesting. See policy_browsertest.cc
for an example.

[binjin, 2014/09/08 12:59:39]

It's browser tests for extensions system, user preference kInstallForcelist was
used here, I don't think it's easy to integrate PolicyProviders here.

Another options is providing SetForceInstallListForTesting(), what do you think?

[Joao da Silva, 2014/09/08 13:18:29]

This test code needs to be updated, because it was relying on setting that pref
at a user level but it should be set at a mandatory policy level.

The way to do that in a test is with a MockConfigurationPolicyProvider passed to
BrowserPolicyConnector::SetPolicyProviderForTesting, and then you can set any
policies in that mock object. policy_browsertest.cc has example code that you
can just copy and paste here.

Note that this test is testing how the extensions code handles an
ExternalPolicyRefresh, so it's fair to require some setup for the policy parts.

[binjin, 2014/09/08 14:52:05]

Got it. Done.

   const base::DictionaryValue* forcelist =
       prefs->GetDictionary(extensions::pref_names::kInstallForceList);
   ASSERT_TRUE(forcelist->empty()) << kForceInstallNotEmptyHelp;
 
   {
     // Set the policy as a user preference and fire notification observers.
     DictionaryPrefUpdate pref_update(prefs,
                                      extensions::pref_names::kInstallForceList);
     base::DictionaryValue* forcelist = pref_update.Get();
     extensions::ExternalPolicyLoader::AddExtension(
@@ skipping 54 matching lines @@
   net::URLFetcher::SetEnableInterceptionForTests(true);
 
   interceptor.SetResponseIgnoreQuery(
       GURL("http://localhost/autoupdate/manifest"),
       basedir.AppendASCII("manifest_v2.xml"));
   interceptor.SetResponseIgnoreQuery(GURL("http://localhost/autoupdate/v2.crx"),
                                      basedir.AppendASCII("v2.crx"));
 
   // Check that the policy is initially empty.
   PrefService* prefs = browser()->profile()->GetPrefs();
+  extensions::ExtensionManagementFactory::GetForBrowserContext(
+      browser()->profile())->AllowUserPreferenceForTesting();
   const base::DictionaryValue* forcelist =
       prefs->GetDictionary(extensions::pref_names::kInstallForceList);
   ASSERT_TRUE(forcelist->empty()) << kForceInstallNotEmptyHelp;
 
   // User install of the extension.
   ASSERT_TRUE(InstallExtension(basedir.AppendASCII("v2.crx"), 1));
   ASSERT_EQ(size_before + 1, registry->enabled_extensions().size());
   const Extension* extension = service->GetExtensionById(kExtensionId, false);
   ASSERT_TRUE(extension);
   EXPECT_EQ(Manifest::INTERNAL, extension->location());
@@ skipping 48 matching lines @@
         forcelist, kExtensionId, "http://localhost/autoupdate/manifest");
   }
   ASSERT_TRUE(WaitForExtensionInstall());
   ASSERT_EQ(size_before + 1, registry->enabled_extensions().size());
   extension = service->GetExtensionById(kExtensionId, false);
   ASSERT_TRUE(extension);
   EXPECT_EQ(Manifest::EXTERNAL_POLICY_DOWNLOAD, extension->location());
   EXPECT_TRUE(service->IsExtensionEnabled(kExtensionId));
   EXPECT_TRUE(registry->disabled_extensions().is_empty());
 }