Issue 536483002: fyi: Remove buildrunner_tests from win_tests, switch chrome_elf_unittests to run without it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 536483002: fyi: Remove buildrunner_tests from win_tests, switch chrome_elf_unittests to run without it. (Closed)

Created:
6 years, 3 months ago by Nico

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews, cmp-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build@master

Project:
tools

Visibility:
Public.

More Reviews

Description

fyi: Remove buildrunner_tests from win_tests, switch chrome_elf_unittests to run without it. buildrunner_tests apparently no longer works on windows (see e.g. crbug.com/409399), and only one test was using it anyways, so run that test normally. Also, while here, remove all --buildtool=ninja parameters, as that's the default these days. BUG=409404, 409399 Reviewed at: https://codereview.chromium.org/531893002/ TBR=rnk Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291772