Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 536183002: Don't always full invalidation on 'position' style change (Closed)

Created:
6 years, 3 months ago by Xianzhu
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@FlexAlignRepaint
Project:
blink
Visibility:
Public.

Description

Don't always full invalidation on 'position' style change Move position changed case from RenderStyle::diffNeedsFullLayoutAndPaintInvalidation() to RenderStyle::diffNeedsFullLayout(). Our layout code can issue invalidations if actually needed. BUG=408697 TEST=fast/repaint/position-change-keeping-geometry.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181423

Patch Set 1 #

Patch Set 2 : Fix test (force z-index to avoid it from changing) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
A LayoutTests/fast/repaint/position-change-keeping-geometry.html View 1 1 chunk +49 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/position-change-keeping-geometry-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Xianzhu
Note that this CL needs https://codereview.chromium.org/538613003/ to work.
6 years, 3 months ago (2014-09-03 22:18:12 UTC) #2
dsinclair
lgtm
6 years, 3 months ago (2014-09-04 14:12:48 UTC) #3
Julien - ping for review
lgtm
6 years, 3 months ago (2014-09-04 17:57:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/536183002/20001
6 years, 3 months ago (2014-09-04 17:58:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/536183002/20001
6 years, 3 months ago (2014-09-04 23:12:36 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 00:23:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181423

Powered by Google App Engine
This is Rietveld 408576698