Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 536183002: Don't always full invalidation on 'position' style change (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@FlexAlignRepaint
Patch Set: Fix test (force z-index to avoid it from changing) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/repaint/position-change-keeping-geometry-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/style/RenderStyle.cpp
diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp
index 6c5d92e353290c20d657bea682c58708ef1468f8..cee0f894f8a154893302580c023b6a008b47f441 100644
--- a/Source/core/rendering/style/RenderStyle.cpp
+++ b/Source/core/rendering/style/RenderStyle.cpp
@@ -543,7 +543,6 @@ bool RenderStyle::diffNeedsFullLayoutAndPaintInvalidation(const RenderStyle& oth
|| noninherited_flags.overflowY != other.noninherited_flags.overflowY
|| noninherited_flags.clear != other.noninherited_flags.clear
|| noninherited_flags.unicodeBidi != other.noninherited_flags.unicodeBidi
- || noninherited_flags.position != other.noninherited_flags.position
|| noninherited_flags.floating != other.noninherited_flags.floating
|| noninherited_flags.originalDisplay != other.noninherited_flags.originalDisplay)
return true;
@@ -604,7 +603,8 @@ bool RenderStyle::diffNeedsFullLayout(const RenderStyle& other) const
return true;
}
- if (noninherited_flags.verticalAlign != other.noninherited_flags.verticalAlign)
+ if (noninherited_flags.verticalAlign != other.noninherited_flags.verticalAlign
+ || noninherited_flags.position != other.noninherited_flags.position)
return true;
if (surround.get() != other.surround.get()) {
« no previous file with comments | « LayoutTests/fast/repaint/position-change-keeping-geometry-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698