content/browser/frame_host/frame_tree_browsertest.cc - Issue 536143002: Do not create proxy hosts in the subtree of navigating frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_browsertest.cc

Issue 536143002: Do not create proxy hosts in the subtree of navigating frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix CrossSiteIframe asserts. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/frame_tree_browsertest.cc

diff --git a/content/browser/frame_host/frame_tree_browsertest.cc b/content/browser/frame_host/frame_tree_browsertest.cc

index d96ee59d10e7784f38e88e264369527ad95acee9..2b02572abbfdd5a05cd074d333720f5fde8df430 100644

--- a/content/browser/frame_host/frame_tree_browsertest.cc

+++ b/content/browser/frame_host/frame_tree_browsertest.cc

@@ -206,7 +206,7 @@ IN_PROC_BROWSER_TEST_F(CrossProcessFrameTreeBrowserTest,

NavigateFrameToURL(root->child_at(0), cross_site_url);

// Ensure that we have created a new process for the subframe.

- ASSERT_EQ(1U, root->child_count());

+ ASSERT_EQ(2U, root->child_count());

FrameTreeNode* child = root->child_at(0);

SiteInstance* child_instance = child->current_frame_host()->GetSiteInstance();

RenderViewHost* rvh = child->current_frame_host()->render_view_host();

« no previous file with comments | « content/browser/frame_host/frame_tree.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »