Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 536063002: Clean up RenderWidgetHostView destruction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Safer scheme Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index 3c987f2a07430bf1d86c300a067895d5c316ccf2..2eb8f97bf95778222fa13e1a1b2043810b63cb2c 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -153,21 +153,14 @@ void RenderWidgetHostViewChildFrame::TextInputStateChanged(
const ViewHostMsg_TextInputState_Params& params) {
}
-void RenderWidgetHostViewChildFrame::RenderProcessGone(
- base::TerminationStatus status,
- int error_code) {
- if (frame_connector_)
- frame_connector_->RenderProcessGone();
- Destroy();
-}
-
void RenderWidgetHostViewChildFrame::Destroy() {
if (frame_connector_) {
+ frame_connector_->RenderProcessGone();
frame_connector_->set_view(NULL);
frame_connector_ = NULL;
}
- host_->SetView(NULL);
+ host_->ViewDestroyed(this);
host_ = NULL;
base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
}

Powered by Google App Engine
This is Rietveld 408576698