Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 536063002: Clean up RenderWidgetHostView destruction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Safer scheme Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_widget_host_view_child_frame.h" 5 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
6 6
7 #include "content/browser/frame_host/cross_process_frame_connector.h" 7 #include "content/browser/frame_host/cross_process_frame_connector.h"
8 #include "content/browser/renderer_host/render_widget_host_impl.h" 8 #include "content/browser/renderer_host/render_widget_host_impl.h"
9 #include "content/common/gpu/gpu_messages.h" 9 #include "content/common/gpu/gpu_messages.h"
10 #include "content/common/view_messages.h" 10 #include "content/common/view_messages.h"
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 } 146 }
147 147
148 void RenderWidgetHostViewChildFrame::SetIsLoading(bool is_loading) { 148 void RenderWidgetHostViewChildFrame::SetIsLoading(bool is_loading) {
149 NOTREACHED(); 149 NOTREACHED();
150 } 150 }
151 151
152 void RenderWidgetHostViewChildFrame::TextInputStateChanged( 152 void RenderWidgetHostViewChildFrame::TextInputStateChanged(
153 const ViewHostMsg_TextInputState_Params& params) { 153 const ViewHostMsg_TextInputState_Params& params) {
154 } 154 }
155 155
156 void RenderWidgetHostViewChildFrame::RenderProcessGone(
157 base::TerminationStatus status,
158 int error_code) {
159 if (frame_connector_)
160 frame_connector_->RenderProcessGone();
161 Destroy();
162 }
163
164 void RenderWidgetHostViewChildFrame::Destroy() { 156 void RenderWidgetHostViewChildFrame::Destroy() {
165 if (frame_connector_) { 157 if (frame_connector_) {
158 frame_connector_->RenderProcessGone();
166 frame_connector_->set_view(NULL); 159 frame_connector_->set_view(NULL);
167 frame_connector_ = NULL; 160 frame_connector_ = NULL;
168 } 161 }
169 162
170 host_->SetView(NULL); 163 host_->ViewDestroyed(this);
171 host_ = NULL; 164 host_ = NULL;
172 base::MessageLoop::current()->DeleteSoon(FROM_HERE, this); 165 base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
173 } 166 }
174 167
175 void RenderWidgetHostViewChildFrame::SetTooltipText( 168 void RenderWidgetHostViewChildFrame::SetTooltipText(
176 const base::string16& tooltip_text) { 169 const base::string16& tooltip_text) {
177 } 170 }
178 171
179 void RenderWidgetHostViewChildFrame::SelectionChanged( 172 void RenderWidgetHostViewChildFrame::SelectionChanged(
180 const base::string16& text, 173 const base::string16& text,
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 333
341 BrowserAccessibilityManager* 334 BrowserAccessibilityManager*
342 RenderWidgetHostViewChildFrame::CreateBrowserAccessibilityManager( 335 RenderWidgetHostViewChildFrame::CreateBrowserAccessibilityManager(
343 BrowserAccessibilityDelegate* delegate) { 336 BrowserAccessibilityDelegate* delegate) {
344 // This eventually needs to be implemented for cross-process iframes. 337 // This eventually needs to be implemented for cross-process iframes.
345 // http://crbug.com/368298 338 // http://crbug.com/368298
346 return NULL; 339 return NULL;
347 } 340 }
348 341
349 } // namespace content 342 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698