Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issue 536053003: Reland net-related fixups for scoped_refptr conversion operator cleanup. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, gavinp+disk_chromium.org, tfarina, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland net-related fixups for scoped_refptr conversion operator cleanup. BUG=110610 TBR=mmenke@chromium.org,pkasting@chromium.org,rsleevi@chromium.org Committed: https://crrev.com/707f860a000925a096b2631be0052affa1b1aec6 Cr-Commit-Position: refs/heads/master@{#293231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -42 lines) Patch
M chrome/browser/ssl/ssl_client_auth_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_auth_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_auth_requestor_mock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_client_auth_requestor_mock.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/simple/simple_index.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_index.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M net/http/transport_security_persister.h View 2 chunks +7 lines, -6 lines 0 comments Download
M net/http/transport_security_persister.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M net/websockets/websocket_inflater_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/536053003/1
6 years, 3 months ago (2014-09-03 20:30:15 UTC) #2
dcheng
(Oops, meant to mail this out before hitting the CQ button.) This is a reland ...
6 years, 3 months ago (2014-09-03 20:31:40 UTC) #3
Ryan Sleevi
lgtm
6 years, 3 months ago (2014-09-03 20:36:23 UTC) #4
mmenke
On 2014/09/03 20:36:23, Ryan Sleevi wrote: > lgtm LGTM
6 years, 3 months ago (2014-09-03 21:38:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 711c3c3676429fbb62dcd5b89e109ef168c4f4ff
6 years, 3 months ago (2014-09-04 00:14:44 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:28:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/707f860a000925a096b2631be0052affa1b1aec6
Cr-Commit-Position: refs/heads/master@{#293231}

Powered by Google App Engine
This is Rietveld 408576698