net/socket/ssl_client_socket_openssl.cc - Issue 536053003: Reland net-related fixups for scoped_refptr conversion operator cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_openssl.cc

Issue 536053003: Reland net-related fixups for scoped_refptr conversion operator cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_openssl.cc

diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc

index 8b5e25a84ae5eaa7dd829eaa3b7e942eb0cd5fde..6600199ec6a8cabf62963795e2e5d4d7ad802486 100644

--- a/net/socket/ssl_client_socket_openssl.cc

+++ b/net/socket/ssl_client_socket_openssl.cc

@@ -1527,7 +1527,7 @@ int SSLClientSocketOpenSSL::CertVerifyCallback(X509_STORE_CTX* store_ctx) {

CHECK(server_cert_.get());

PeerCertificateChain chain(store_ctx->untrusted);

- if (chain.IsValid() && server_cert_->Equals(chain.AsOSChain()))

+ if (chain.IsValid() && server_cert_->Equals(chain.AsOSChain().get()))

return 1;

if (!chain.IsValid())

« no previous file with comments | « net/http/transport_security_persister.cc ('k') | net/socket/ssl_client_socket_pool.cc » ('j') | no next file with comments »