Decoupling visibility states from webcontent, adding visibility management in ResourceManager

athena/content/app_activity_registry.h

Index: athena/content/app_activity_registry.h
diff --git a/athena/content/app_activity_registry.h b/athena/content/app_activity_registry.h
index 14ef7de3945ba25b7e9ec445b63f1b786f07307b..bd9b685abc3769e7e7ad19398aada1d42b422fdb 100644
--- a/athena/content/app_activity_registry.h
+++ b/athena/content/app_activity_registry.h
@@ -57,9 +57,9 @@ class ATHENA_EXPORT AppActivityRegistry {
   content::BrowserContext* browser_context() const { return browser_context_; }
   const std::string& app_id() const { return app_id_; }
 
-  AppActivityProxy* unloaded_activity_proxy_for_test() {
-    return unloaded_activity_proxy_;
-  }
+  // Returns the proxy - if there is one. This will get used by a newly created
+  // activity to position itself in its place before it get destroyed.
+  Activity* unloaded_activity_proxy() const { return unloaded_activity_proxy_; }

[oshima, 2014/09/04 16:39:23]

remove const

(a method that returns non const internal object should be non const.)

[Mr4D (OOO till 08-26), 2014/09/04 19:10:57]

Done.

 
  protected:
   friend AppActivityProxy;
@@ -74,8 +74,8 @@ class ATHENA_EXPORT AppActivityRegistry {
   void RestartApplication(AppActivityProxy* proxy);
 
  private:
-  // Move the window before the most recently used application window.
-  void MoveBeforeMruApplicationWindow(aura::Window* window);
+  // Get the most recently used activity.

[oshima, 2014/09/04 22:11:01]

how about

// Gets most recently used AppAcitivty that belongs to the same application.

?

[Mr4D (OOO till 08-26), 2014/09/04 22:36:51]

Done.

+  AppActivity* GetMruActivity();
 
   // A list of all activities associated with this application.
   std::vector<AppActivity*> activity_list_;