Decoupling visibility states from webcontent, adding visibility management in ResourceManager

athena/content/app_activity_registry.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ATHENA_CONTENT_APP_ACTIVITY_REGISTRY_H_
 #define ATHENA_CONTENT_APP_ACTIVITY_REGISTRY_H_
 
 #include <vector>
 
 #include "athena/activity/public/activity_view_model.h"
@@ skipping 39 matching lines @@
 
   // Unload all application associated activities to save resources.
   void Unload();
 
   // Returns true if the application is in the unloaded state.
   bool IsUnloaded() { return unloaded_activity_proxy_ != NULL; }
 
   content::BrowserContext* browser_context() const { return browser_context_; }
   const std::string& app_id() const { return app_id_; }
 
-  AppActivityProxy* unloaded_activity_proxy_for_test() {
-    return unloaded_activity_proxy_;
-  }
+  // Returns the proxy - if there is one. This will get used by a newly created
+  // activity to position itself in its place before it get destroyed.
+  Activity* unloaded_activity_proxy() const { return unloaded_activity_proxy_; }

[oshima, 2014/09/04 16:39:23]

remove const

(a method that returns non const internal object should be non const.)

[Mr4D (OOO till 08-26), 2014/09/04 19:10:57]

Done.

 
  protected:
   friend AppActivityProxy;
 
   // When the |AppActivityProxy| gets destroyed it should call this function
   // to disconnect from this object. This call might destroy |this|.
   void ProxyDestroyed(AppActivityProxy* proxy);
 
   // When called by the |AppActivityProxy| to restart the application, it can
   // cause the application to restart. When that happens the proxy will get
   // destroyed. After this call |this| might be destroyed.
   void RestartApplication(AppActivityProxy* proxy);
 
  private:
-  // Move the window before the most recently used application window.
-  void MoveBeforeMruApplicationWindow(aura::Window* window);
+  // Get the most recently used activity.

[oshima, 2014/09/04 22:11:01]

how about

// Gets most recently used AppAcitivty that belongs to the same application.

?

[Mr4D (OOO till 08-26), 2014/09/04 22:36:51]

Done.

+  AppActivity* GetMruActivity();
 
   // A list of all activities associated with this application.
   std::vector<AppActivity*> activity_list_;
 
   // The application id for this proxy.
   std::string app_id_;
 
   // The browser context of the user.
   content::BrowserContext* browser_context_;
 
   // When the activity is unloaded this is the AppActivityProxy. The object is
   // owned the the ActivityManager.
   AppActivityProxy* unloaded_activity_proxy_;
 
   // The presentation values.
   SkColor color_;
   base::string16 title_;
   gfx::ImageSkia image_;
 
   DISALLOW_COPY_AND_ASSIGN(AppActivityRegistry);
 };
 
 }  // namespace athena
 
 #endif  // ATHENA_CONTENT_APP_ACTIVITY_REGISTRY_H_