Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 536003002: Hide fields in SkImageInfo (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Hide fields in SkImageInfo TBR=bsalomon Committed: https://skia.googlesource.com/skia/+/e5ea500d4714a7d84de2bf913e81be3b65d2de68

Patch Set 1 #

Patch Set 2 : document 4 in gradients, fix SkNulCanvas.h #

Patch Set 3 : rebase #

Patch Set 4 : fix qt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -223 lines) Patch
M bench/WritePixelsBench.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M bench/nanobench.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M debugger/QT/SkImageWidget.cpp View 1 2 3 1 chunk +3 lines, -7 lines 0 comments Download
M experimental/PdfViewer/SkNulCanvas.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkBitmap.h View 4 chunks +10 lines, -14 lines 0 comments Download
M include/core/SkImageInfo.h View 4 chunks +39 lines, -28 lines 0 comments Download
M samplecode/SampleFatBits.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkBitmap.cpp View 11 chunks +29 lines, -38 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M src/core/SkMallocPixelRef.cpp View 4 chunks +6 lines, -7 lines 0 comments Download
M src/core/SkPixelRef.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/images/SkDecodingImageGenerator.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/lazy/SkCachingPixelRef.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/BitmapTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/BlitRowTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 chunk +7 lines, -9 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/SurfaceTest.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/LazyDecodeBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/536003002/1
6 years, 3 months ago (2014-09-03 16:16:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/536003002/20001
6 years, 3 months ago (2014-09-03 18:21:20 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86_64-Release-Trybot on tryserver.skia ...
6 years, 3 months ago (2014-09-03 18:29:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/536003002/40001
6 years, 3 months ago (2014-09-03 18:33:23 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86_64-Release-Trybot on tryserver.skia ...
6 years, 3 months ago (2014-09-03 18:41:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/536003002/60001
6 years, 3 months ago (2014-09-03 18:46:25 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 18:55:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as e5ea500d4714a7d84de2bf913e81be3b65d2de68

Powered by Google App Engine
This is Rietveld 408576698