Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 535913002: Add scrollbar logical width while computing intrinsic logical width (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding Test case Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderGrid.cpp
diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp
index e7daaecd24e539d34fa4095dad4fb805159dccc8..e81c58ec5ea6bd9bb8212ba5236df45f6984c965 100644
--- a/Source/core/rendering/RenderGrid.cpp
+++ b/Source/core/rendering/RenderGrid.cpp
@@ -376,7 +376,11 @@ void RenderGrid::computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, Layo
minLogicalWidth += minTrackBreadth;
maxLogicalWidth += maxTrackBreadth;
- // FIXME: This should add in the scrollbarWidth (e.g. see RenderFlexibleBox).
+ maxLogicalWidth = std::max(minLogicalWidth, maxLogicalWidth);
Julien - ping for review 2014/09/09 14:39:40 Is this max required as we ensure that minTrackBre
Sunil Ratnu 2014/09/09 15:22:55 In this case, its not needed as before calling com
+
+ LayoutUnit scrollbarWidth = instrinsicScrollbarLogicalWidth();
Julien - ping for review 2014/09/09 14:39:40 Let's correct the typo in the function name while
Sunil Ratnu 2014/09/09 17:28:30 Done.
+ maxLogicalWidth += scrollbarWidth;
+ minLogicalWidth += scrollbarWidth;
}
}

Powered by Google App Engine
This is Rietveld 408576698