Add scrollbar logical width while computing intrinsic logical width

Source/core/rendering/RenderGrid.cpp

 /*
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 358 matching lines @@
     const_cast<RenderGrid*>(this)->computeUsedBreadthOfGridTracks(ForColumns, sizingData, availableLogicalSpace);
 
     for (size_t i = 0; i < sizingData.columnTracks.size(); ++i) {
         LayoutUnit minTrackBreadth = sizingData.columnTracks[i].m_usedBreadth;
         LayoutUnit maxTrackBreadth = sizingData.columnTracks[i].m_maxBreadth;
         maxTrackBreadth = std::max(maxTrackBreadth, minTrackBreadth);
 
         minLogicalWidth += minTrackBreadth;
         maxLogicalWidth += maxTrackBreadth;
 
-        // FIXME: This should add in the scrollbarWidth (e.g. see RenderFlexibleBox).
+        maxLogicalWidth = std::max(minLogicalWidth, maxLogicalWidth);

[Julien - ping for review, 2014/09/09 14:39:40]

Is this max required as we ensure that minTrackBreadth is less than
maxTrackBreadth above?

[Sunil Ratnu, 2014/09/09 15:22:55]

In this case, its not needed as before calling computeIntrinsicLogicalWidths(),
we have
minLogicalWidth = maxLogicalWidth = 0; But I was unsure that this will always
remain equal or 0 because of the FIXME present in
computePreferredLogicalWidths(), hence thought of keeping std::max here (Can be
handy in cases when we have different values for these).

I will upload the next patch including this as well other changes once we can be
sure of what to with std::max.

Please do let me know whether we should still keep it or not?

+
+        LayoutUnit scrollbarWidth = instrinsicScrollbarLogicalWidth();

[Julien - ping for review, 2014/09/09 14:39:40]

Let's correct the typo in the function name while touching this code (it should
be intrinsicScrollbarLogicalWidth).

[Sunil Ratnu, 2014/09/09 17:28:30]

Done.

+        maxLogicalWidth += scrollbarWidth;
+        minLogicalWidth += scrollbarWidth;
     }
 }
 
 void RenderGrid::computePreferredLogicalWidths()
 {
     ASSERT(preferredLogicalWidthsDirty());
 
     m_minPreferredLogicalWidth = 0;
     m_maxPreferredLogicalWidth = 0;
 
@@ skipping 1057 matching lines @@
     if (isOutOfFlowPositioned())
         return "RenderGrid (positioned)";
     if (isAnonymous())
         return "RenderGrid (generated)";
     if (isRelPositioned())
         return "RenderGrid (relative positioned)";
     return "RenderGrid";
 }
 
 } // namespace blink