Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 53583005: Fix typo in simple-polygon.js LayoutTest helper (Closed)

Created:
7 years, 1 month ago by Steve Block
Modified:
7 years, 1 month ago
Reviewers:
Hans Muller
CC:
blink-reviews
Visibility:
Public.

Description

Fix typo in simple-polygon.js LayoutTest helper The lineHeight parameter to generatePolygonContentString() is mistyped as 'lineheight'. It looks like this bug has always been present. It doesn't currently create a problem because in all cases where this function is called, a global variable named 'lineHeight' exists with the correct value. See https://src.chromium.org/viewvc/blink?view=revision&revision=130687 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/fast/shapes/resources/simple-polygon.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Steve Block
7 years, 1 month ago (2013-10-31 02:39:59 UTC) #1
Hans Muller
On 2013/10/31 02:39:59, Steve Block wrote: This change LGTM and I have to admit that ...
7 years, 1 month ago (2013-10-31 04:13:55 UTC) #2
Steve Block
We've been working on animating line-height in Web Animations and I happened to do this ...
7 years, 1 month ago (2013-10-31 23:14:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/53583005/1
7 years, 1 month ago (2013-10-31 23:14:55 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 00:12:41 UTC) #5
Message was sent while issue was closed.
Change committed as 161112

Powered by Google App Engine
This is Rietveld 408576698