Add --max-failures command line argument to override that in PageTest.

Add --max-failures command line argument to override that in PageTest.

Needed to try to reproduce intermittent failures on tryservers.

BUG=407976
Committed: https://crrev.com/314c0991fd6cb2f7dd58874a613212d041141123
Cr-Commit-Position: refs/heads/master@{#293069}

[Ken Russell (switch to Gerrit), 2014-09-03 00:45:09]

kbr@chromium.org changed reviewers:
+ dtu@chromium.org

[Ken Russell (switch to Gerrit), 2014-09-03 00:45:10]

David: please review. Thanks.

This is needed in order to be able to early-exit from tests being run in a long
loop, without changing the code of those tests.

[dtu, 2014-09-03 00:50:43]

https://chromiumcodereview.appspot.com/535743002/diff/1/tools/telemetry/telem...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://chromiumcodereview.appspot.com/535743002/diff/1/tools/telemetry/telem...
tools/telemetry/telemetry/page/page_runner.py:410: if not test.max_failures is
None:
File a followup bug to fix the definition of max_failures to remove off-by-1
error

https://chromiumcodereview.appspot.com/535743002/diff/1/tools/telemetry/telem...
File tools/telemetry/telemetry/page/page_runner_unittest.py (right):

https://chromiumcodereview.appspot.com/535743002/diff/1/tools/telemetry/telem...
tools/telemetry/telemetry/page/page_runner_unittest.py:610:
expected_max_failures = max_failures
You don't want to reset the value you pass to Test()

[Ken Russell (switch to Gerrit), 2014-09-03 00:57:24]

https://codereview.chromium.org/535743002/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/535743002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_runner.py:410: if not test.max_failures is
None:
On 2014/09/03 00:50:43, dtu wrote:
> File a followup bug to fix the definition of max_failures to remove off-by-1
> error

Done: http://crbug.com/410117

https://codereview.chromium.org/535743002/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_runner_unittest.py (right):

https://codereview.chromium.org/535743002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_runner_unittest.py:610:
expected_max_failures = max_failures
On 2014/09/03 00:50:43, dtu wrote:
> You don't want to reset the value you pass to Test()

Thanks. Fixed.

[dtu, 2014-09-03 00:59:24]

The CQ bit was checked by dtu@chromium.org

[dtu, 2014-09-03 00:59:25]

lgtm

[commit-bot: I haz the power, 2014-09-03 01:02:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kbr@chromium.org/535743002/20001

[commit-bot: I haz the power, 2014-09-03 02:39:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-09-03 04:54:47]

Committed patchset #2 (id:20001) as 81a392bc2409d0a48eea26f6838af09437412003

[commit-bot: I haz the power, 2014-09-10 03:23:29]

Patchset 2 (id:??) landed as
https://crrev.com/314c0991fd6cb2f7dd58874a613212d041141123
Cr-Commit-Position: refs/heads/master@{#293069}