Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 535743002: Add --max-failures command line argument to override that in PageTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review feedback from dtu. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index d96ce45b62d3c599352d9096cc9adc799d6dd74a..9b55958f79d7a26e85dfa529773152c08d8577b2 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -205,6 +205,10 @@ def AddCommandLineArgs(parser):
'before proceeding with the next page in the pageset.')
group.add_option('--pageset-repeat', default=1, type='int',
help='Number of times to repeat the entire pageset.')
+ group.add_option('--max-failures', default=None, type='int',
+ help='Maximum number of test failures before aborting '
+ 'the run. Defaults to the number specified by the '
+ 'PageTest.')
parser.add_option_group(group)
# WPR options
@@ -402,6 +406,13 @@ def Run(test, page_set, expectations, finder_options, results):
state = _RunState()
# TODO(dtu): Move results creation and results_for_current_run into RunState.
+ max_failures = None
+ if not test.max_failures is None:
+ max_failures = test.max_failures
+ if not finder_options.max_failures is None:
+ # Support overriding this from the command line.
+ max_failures = finder_options.max_failures
+
try:
test.WillRunTest(finder_options)
for _ in xrange(0, finder_options.pageset_repeat):
@@ -424,8 +435,8 @@ def Run(test, page_set, expectations, finder_options, results):
discard_run = True
results.DidRunPage(page, discard_run=discard_run)
test.DidRunPageRepeats(page)
- if (not test.max_failures is None and
- len(results.failures) > test.max_failures):
+ if (not max_failures is None and
+ len(results.failures) > max_failures):
logging.error('Too many failures. Aborting.')
test.RequestExit()
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698