Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 535733005: Measure current usage statistics for MediaStream label and stop() before going for deprecation. (Closed)

Created:
6 years, 3 months ago by Vinod Keshav
Modified:
6 years, 2 months ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Measure current usage statistics for MediaStream label and stop() before going for deprecation. As per spec, both label and stop have been deprecated. Spec = http://dev.w3.org/2011/webrtc/editor/getusermedia.html#mediastream BUG=407039 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182408

Patch Set 1 #

Patch Set 2 : Resolving Merge Error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/mediastream/MediaStream.idl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
Vinod Keshav
PTAL
6 years, 3 months ago (2014-09-03 09:40:36 UTC) #2
Henrik Grunell
LGTM. Just FTR, label and id are the same (renamed). Removing label will finalize the ...
6 years, 3 months ago (2014-09-04 08:20:29 UTC) #3
Vinod Keshav
On 2014/09/04 08:20:29, Henrik Grunell wrote: > LGTM. > > Just FTR, label and id ...
6 years, 3 months ago (2014-09-10 09:49:06 UTC) #4
Vinod Keshav
On 2014/09/10 09:49:06, Vinod Keshav wrote: > On 2014/09/04 08:20:29, Henrik Grunell wrote: > > ...
6 years, 3 months ago (2014-09-16 02:57:19 UTC) #5
Vinod Keshav
haraken@ PTAL
6 years, 3 months ago (2014-09-22 07:19:40 UTC) #7
haraken
Just to confirm: You want to use [MeasureAs], not [DeprecateAs]?
6 years, 3 months ago (2014-09-22 08:04:15 UTC) #8
Vinod Keshav
On 2014/09/22 08:04:15, haraken wrote: > Just to confirm: You want to use [MeasureAs], not ...
6 years, 3 months ago (2014-09-22 08:18:14 UTC) #9
haraken
LGTM
6 years, 3 months ago (2014-09-22 08:19:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/535733005/1
6 years, 3 months ago (2014-09-22 08:45:47 UTC) #12
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-09-22 08:45:55 UTC) #14
Vinod Keshav
6 years, 3 months ago (2014-09-22 09:33:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/535733005/20001
6 years, 3 months ago (2014-09-22 09:34:24 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 182408
6 years, 3 months ago (2014-09-22 11:19:58 UTC) #20
Erik Corry
It seems the corresponding change was not done on the Chromium tools side, or perhaps ...
6 years, 2 months ago (2014-10-01 13:59:25 UTC) #22
Henrik Grunell
6 years, 2 months ago (2014-10-03 07:54:40 UTC) #23
Message was sent while issue was closed.
On 2014/10/01 13:59:25, Erik Corry wrote:
> It seems the corresponding change was not done on the Chromium tools side, or
> perhaps I am missing something. See https://codereview.chromium.org/622543003

You're right that it's missing. In fact, I hadn't thought of the Chromium change
(not mentioned in
http://www.chromium.org/blink#TOC-Web-Platform-Changes:-Process). But now it's
obvious, Thanks.

Powered by Google App Engine
This is Rietveld 408576698