Issue 53573004: Introduce orps for IA32/X64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53573004: Introduce orps for IA32/X64 (Closed)

Created:
7 years, 1 month ago by Weiliang

Modified:
7 years, 1 month ago

Reviewers:
Sven Panne, haitao.feng

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@upstream

Visibility:
Public.

More Reviews

Description

Introduce orps for IA32/X64 BUG= R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17479

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -27 lines)			Patch
M	src/ia32/assembler-ia32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	2 chunks	+16 lines, -8 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	3 chunks	+3 lines, -3 lines	1 comment	Download
M	src/ia32/lithium-gap-resolver-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/assembler-x64.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/assembler-x64.cc	View	2 chunks	+18 lines, -9 lines	0 comments	Download
M	src/x64/disasm-x64.cc	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-gap-resolver-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-disasm-ia32.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-disasm-x64.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM, I'll land it for you... https://codereview.chromium.org/53573004/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/53573004/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2187 src/ia32/lithium-codegen-ia32.cc:2187: __ movaps(left_reg, right_reg); ...

7 years, 1 month ago (2013-11-04 14:05:45 UTC) #2

Sven Panne

7 years, 1 month ago (2013-11-05 12:04:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17479 (presubmit successful).

Expand Messages | Collapse Messages