Source/core/html/HTMLMediaElement.cpp - Issue 535703002: HTMLMediaElement shouldn't call currentTime() when we HAVE_NOTHING.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 535703002: HTMLMediaElement shouldn't call currentTime() when we HAVE_NOTHING. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 91ef6708e6f5e78594ef9b36ad751aec9955cc39..2442d76f5b33e686931b4c908901557862c7df43 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -2047,7 +2047,7 @@ bool HTMLMediaElement::seeking() const

void HTMLMediaElement::refreshCachedTime() const

{

- if (!webMediaPlayer())

+ if (!webMediaPlayer() || m_readyState < HAVE_METADATA)

return;

m_cachedTime = webMediaPlayer()->currentTime();

acolwell GONE FROM CHROMIUM 2014/09/03 00:21:42 nit: Add a comment indicating that this only conta

scherkus (not reviewing) 2014/09/03 03:27:44 Done in .h

« no previous file with comments | « no previous file | no next file » | no next file with comments »