HTMLMediaElement shouldn't call currentTime() when we HAVE_NOTHING.

Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 774 matching lines @@
         m_seeking = false;
 
         // 4.7 - Set the current playback position to 0.
         //       Set the official playback position to 0.
         //       If this changed the official playback position, then queue a task to fire a simple event named timeupdate at the media element.
         // FIXME: Add support for firing this event.
 
         // 4.8 - Set the initial playback position to 0.
         // FIXME: Make this less subtle. The position only becomes 0 because of the createMediaPlayer() call
         // above.
         refreshCachedTime();

[acolwell GONE FROM CHROMIUM, 2014/09/03 00:21:42]

I think you should be able to remove this call now.

[scherkus (not reviewing), 2014/09/03 03:27:45]

Done ... it's tough to figure out the original intent of this code but I believe
my updated FIXME is accurate. LMKWYT.

         invalidateCachedTime();
 
         // 4.9 - Set the timeline offset to Not-a-Number (NaN).
         // 4.10 - Update the duration attribute to Not-a-Number (NaN).
 
 
         updateMediaController();
         updateActiveTextTrackCues(0);
     }
 
@@ skipping 1234 matching lines @@
     return webMediaPlayer() && webMediaPlayer()->hasAudio();
 }
 
 bool HTMLMediaElement::seeking() const
 {
     return m_seeking;
 }
 
 void HTMLMediaElement::refreshCachedTime() const
 {
-    if (!webMediaPlayer())
+    if (!webMediaPlayer() || m_readyState < HAVE_METADATA)
         return;
 
     m_cachedTime = webMediaPlayer()->currentTime();

[acolwell GONE FROM CHROMIUM, 2014/09/03 00:21:42]

nit: Add a comment indicating that this only contains a valid value when
m_readyState >= HAVE_METADATA?

[scherkus (not reviewing), 2014/09/03 03:27:44]

Done in .h

     m_cachedTimeWallClockUpdateTime = WTF::currentTime();

[acolwell GONE FROM CHROMIUM, 2014/09/03 00:21:42]

Mind removing this while you are in here? The value appears to never be read.

[scherkus (not reviewing), 2014/09/03 03:27:44]

Done.

I actually think we can nuke all this cached time business as I don't think it
affects Chromium's media engines, but that can be a future CL.

 }
 
 void HTMLMediaElement::invalidateCachedTime()
 {
     WTF_LOG(Media, "HTMLMediaElement::invalidateCachedTime");
 
     // Don't try to cache movie time when playback first starts as the time reported by the engine
     // sometimes fluctuates for a short amount of time, so the cached time will be off if we take it
     // too early.
     static const double minimumTimePlayingBeforeCacheSnapshot = 0.5;
 
     m_minimumWallClockTimeToCacheMediaTime = WTF::currentTime() + minimumTimePlayingBeforeCacheSnapshot;

[acolwell GONE FROM CHROMIUM, 2014/09/03 00:21:42]

ditto

[scherkus (not reviewing), 2014/09/03 03:27:44]

Done.

     m_cachedTime = MediaPlayer::invalidTime();
 }
 
 // playback state
 double HTMLMediaElement::currentTime() const
 {
 #if LOG_CACHED_TIME_WARNINGS
     static const double minCachedDeltaForWarning = 0.01;

[acolwell GONE FROM CHROMIUM, 2014/09/03 00:21:42]

move this into the block below so we only have 1 #ifdef or remove the code
altogether?

[scherkus (not reviewing), 2014/09/03 03:27:45]

Done.

 #endif
 
     if (m_readyState == HAVE_NOTHING)
         return 0;
 
     if (m_seeking) {
         WTF_LOG(Media, "HTMLMediaElement::currentTime - seeking, returning %f", m_lastSeekTime);
         return m_lastSeekTime;
     }
 
@@ skipping 1324 matching lines @@
         m_networkState = NETWORK_IDLE;
 
     // 5 - Set the element's delaying-the-load-event flag to false. This stops delaying the load event.
     setShouldDelayLoadEvent(false);
 
     // 6 - Abort the overall resource selection algorithm.
     m_currentSourceNode = nullptr;
 
     // Reset m_readyState since m_player is gone.
     m_readyState = HAVE_NOTHING;
     updateMediaController();

[acolwell GONE FROM CHROMIUM, 2014/09/03 00:21:42]

Add invalidateCachedTime() call here just to be consistent?

[scherkus (not reviewing), 2014/09/03 03:27:45]

Done.

     updateActiveTextTrackCues(0);
 }
 
 void HTMLMediaElement::clearMediaPlayerAndAudioSourceProviderClientWithoutLocking()
 {
 #if ENABLE(WEB_AUDIO)
     if (audioSourceProvider())
         audioSourceProvider()->setClient(0);
 #endif
     m_player.clear();
@@ skipping 559 matching lines @@
 
 #if ENABLE(WEB_AUDIO)
 void HTMLMediaElement::clearWeakMembers(Visitor* visitor)
 {
     if (!visitor->isAlive(m_audioSourceNode) && audioSourceProvider())
         audioSourceProvider()->setClient(0);
 }
 #endif
 
 }