Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 535613002: GN: Build libvpx (Closed)

Created:
6 years, 3 months ago by Alpha Left Google
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

GN: Build libvpx * Changes the include order of YASM Default includes need to be put to the end for YASM. In particular there are several versions of x86inc.asm in the tree and libvpx requires its own version. This change in order allows libvpx to include its own version. * Roll libvpx to include BUILD.gn. libvpx now builds on x86 posix. R=brettw@chromium.org, scherkus@chromium.org, tomfinegan@chromium.org Committed: https://crrev.com/01da7dc6500d682cfcef81553d5e1d673654b166 Cr-Commit-Position: refs/heads/master@{#294932}

Patch Set 1 #

Patch Set 2 : build libvpx #

Total comments: 1

Patch Set 3 : merged #

Patch Set 4 : done now #

Patch Set 5 : no neon #

Patch Set 6 : exclude arm neon intrinsics #

Patch Set 7 : removed neon intrinsics for good #

Patch Set 8 : build on ARM NEON #

Patch Set 9 : arm neon #

Patch Set 10 : compile arm now #

Patch Set 11 : merged #

Patch Set 12 : new deps #

Patch Set 13 : git cl try #

Patch Set 14 : merged #

Patch Set 15 : merged #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -36 lines) Patch
M DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M media/cast/BUILD.gn View 1 2 3 4 5 6 7 8 6 chunks +14 lines, -21 lines 0 comments Download
M media/media_options.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/yasm_assemble.gni View 1 2 3 4 5 6 7 8 9 10 2 chunks +14 lines, -13 lines 1 comment Download

Messages

Total messages: 31 (11 generated)
Alpha Left Google
6 years, 3 months ago (2014-09-02 22:15:35 UTC) #2
Alpha Left Google
ping ping
6 years, 3 months ago (2014-09-05 21:32:35 UTC) #3
brettw
lgtm https://codereview.chromium.org/535613002/diff/20001/third_party/yasm/yasm_assemble.gni File third_party/yasm/yasm_assemble.gni (right): https://codereview.chromium.org/535613002/diff/20001/third_party/yasm/yasm_assemble.gni#newcode145 third_party/yasm/yasm_assemble.gni:145: # work). This is because rebase_path will terminate ...
6 years, 3 months ago (2014-09-05 21:55:07 UTC) #5
Alpha Left Google
On 2014/09/05 21:55:07, brettw wrote: > lgtm > > https://codereview.chromium.org/535613002/diff/20001/third_party/yasm/yasm_assemble.gni > File third_party/yasm/yasm_assemble.gni (right): > ...
6 years, 3 months ago (2014-09-06 08:29:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/535613002/240001
6 years, 3 months ago (2014-09-13 02:08:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10796)
6 years, 3 months ago (2014-09-13 02:20:27 UTC) #10
Alpha Left Google
+scherkus for media approval.
6 years, 3 months ago (2014-09-13 02:23:53 UTC) #12
Alpha Left Google
On 2014/09/13 02:23:53, Alpha wrote: > +scherkus for media approval. This is all ready to ...
6 years, 3 months ago (2014-09-13 04:49:46 UTC) #13
Alpha Left Google
Ping scherkus.
6 years, 3 months ago (2014-09-15 19:35:53 UTC) #14
Tom Finegan
On 2014/09/15 19:35:53, Alpha wrote: > Ping scherkus. lgtm [extremely late rs]
6 years, 3 months ago (2014-09-15 19:42:55 UTC) #15
scherkus (not reviewing)
lgtm
6 years, 3 months ago (2014-09-15 19:49:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/535613002/240001
6 years, 3 months ago (2014-09-15 20:05:24 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11048)
6 years, 3 months ago (2014-09-15 20:15:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/535613002/260001
6 years, 3 months ago (2014-09-15 20:58:08 UTC) #22
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-15 22:23:53 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/535613002/280001
6 years, 3 months ago (2014-09-15 22:39:29 UTC) #26
Alpha Left Google
Committed patchset #15 (id:280001) to pending queue manually as 4ac8bb1 (presubmit successful).
6 years, 3 months ago (2014-09-15 23:56:28 UTC) #27
commit-bot: I haz the power
Patchset 15 (id:??) landed as https://crrev.com/01da7dc6500d682cfcef81553d5e1d673654b166 Cr-Commit-Position: refs/heads/master@{#294932}
6 years, 3 months ago (2014-09-15 23:57:07 UTC) #28
piman
https://codereview.chromium.org/535613002/diff/280001/third_party/yasm/yasm_assemble.gni File third_party/yasm/yasm_assemble.gni (left): https://codereview.chromium.org/535613002/diff/280001/third_party/yasm/yasm_assemble.gni#oldcode87 third_party/yasm/yasm_assemble.gni:87: "-I.", This (recently added) line was lost in the ...
6 years, 3 months ago (2014-09-18 20:14:57 UTC) #30
piman
6 years, 3 months ago (2014-09-18 20:17:47 UTC) #31
Message was sent while issue was closed. 
On 2014/09/18 20:14:57, piman (Very slow to review) wrote:
>
https://codereview.chromium.org/535613002/diff/280001/third_party/yasm/yasm_a...
> File third_party/yasm/yasm_assemble.gni (left):
> 
>
https://codereview.chromium.org/535613002/diff/280001/third_party/yasm/yasm_a...
> third_party/yasm/yasm_assemble.gni:87: "-I.",
> This (recently added) line was lost in the merge.

https://codereview.chromium.org/583753002/

Powered by Google App Engine
This is Rietveld 408576698