Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 535243002: Disable the Mac "Access Address Book" Autofill popup. (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
erikchen, Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable the Mac "Access Address Book" Autofill popup. The intent of this patch is to create something small and harmless for merging to M38. The prompt will be reenabled as soon as the logic for showing it is updated. BUG=408695 R=erikchen@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1e021cbcac7e8370dc5c51110ee9aceaaa900ca5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/autofill/core/browser/autofill_external_delegate.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Evan Stade
6 years, 3 months ago (2014-09-03 17:20:44 UTC) #2
erikchen
lgtm
6 years, 3 months ago (2014-09-03 17:23:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/535243002/1
6 years, 3 months ago (2014-09-03 23:23:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1901)
6 years, 3 months ago (2014-09-04 02:11:20 UTC) #7
Evan Stade
Committed patchset #1 (id:1) manually as 1e021cb (presubmit successful).
6 years, 3 months ago (2014-09-04 18:06:23 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e021cbcac7e8370dc5c51110ee9aceaaa900ca5
Cr-Commit-Position: refs/heads/master@{#293320}

Powered by Google App Engine
This is Rietveld 408576698