Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1696)

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 535243002: Disable the Mac "Access Address Book" Autofill popup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_external_delegate.cc
diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc
index 57777c8e37c8e90abea955977f67648bd4246c3e..80ad335a44a0e4c50f92eb406bdb0d6884ee5045 100644
--- a/components/autofill/core/browser/autofill_external_delegate.cc
+++ b/components/autofill/core/browser/autofill_external_delegate.cc
@@ -117,6 +117,8 @@ void AutofillExternalDelegate::OnSuggestionsReturned(
// updated to match.
InsertDataListValues(&values, &labels, &icons, &ids);
+// Temporarily disabled. See http://crbug.com/408695
+#if 0
#if defined(OS_MACOSX) && !defined(OS_IOS)
if (values.empty() &&
manager_->ShouldShowAccessAddressBookSuggestion(query_form_,
@@ -130,6 +132,7 @@ void AutofillExternalDelegate::OnSuggestionsReturned(
EmitHistogram(SHOWED_ACCESS_ADDRESS_BOOK_ENTRY);
}
#endif // defined(OS_MACOSX) && !defined(OS_IOS)
+#endif
if (values.empty()) {
// No suggestions, any popup currently showing is obsolete.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698