Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 535073005: Convert Print Preview layout and color radio buttons to select elements. (Closed)

Created:
6 years, 3 months ago by Aleksey Shlyapnikov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert Print Preview layout and color radio buttons to select elements. BUG=397741 Committed: https://crrev.com/01a16bc2d4c9e667c60efe42a68fbcf9bbc09e85 Cr-Commit-Position: refs/heads/master@{#293811}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merging with head #

Patch Set 3 : Adapt browser_tests to the controls change. #

Messages

Total messages: 26 (12 generated)
Aleksey Shlyapnikov
6 years, 3 months ago (2014-09-04 04:53:45 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/535073005/diff/1/chrome/browser/resources/print_preview/settings/color_settings.js File chrome/browser/resources/print_preview/settings/color_settings.js (right): https://codereview.chromium.org/535073005/diff/1/chrome/browser/resources/print_preview/settings/color_settings.js#newcode64 chrome/browser/resources/print_preview/settings/color_settings.js:64: this.colorTicketItem_.updateValue(isColor); DOn't you need updateUiStateInternal here?
6 years, 3 months ago (2014-09-04 21:41:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/535073005/1
6 years, 3 months ago (2014-09-05 00:16:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/11163) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/13235)
6 years, 3 months ago (2014-09-05 04:52:31 UTC) #7
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/535073005/diff/1/chrome/browser/resources/print_preview/settings/color_settings.js File chrome/browser/resources/print_preview/settings/color_settings.js (right): https://codereview.chromium.org/535073005/diff/1/chrome/browser/resources/print_preview/settings/color_settings.js#newcode64 chrome/browser/resources/print_preview/settings/color_settings.js:64: this.colorTicketItem_.updateValue(isColor); On 2014/09/04 21:41:30, Vitaly Buka wrote: > DOn't ...
6 years, 3 months ago (2014-09-05 06:20:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/535073005/1
6 years, 3 months ago (2014-09-05 16:35:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/11347) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10682)
6 years, 3 months ago (2014-09-05 16:44:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/535073005/1
6 years, 3 months ago (2014-09-05 17:14:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10705) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/9366)
6 years, 3 months ago (2014-09-05 17:22:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/535073005/20001
6 years, 3 months ago (2014-09-08 17:41:35 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/11925) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/13994)
6 years, 3 months ago (2014-09-08 19:27:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/535073005/40001
6 years, 3 months ago (2014-09-08 21:56:45 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a0bb1d0cce1dbd43f4f794eafe1c3adfb2a57060
6 years, 3 months ago (2014-09-08 23:29:22 UTC) #25
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:48:57 UTC) #26
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/01a16bc2d4c9e667c60efe42a68fbcf9bbc09e85
Cr-Commit-Position: refs/heads/master@{#293811}

Powered by Google App Engine
This is Rietveld 408576698