chrome/browser/resources/print_preview/print_preview.js - Issue 535073005: Convert Print Preview layout and color radio buttons to select elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 535073005: Convert Print Preview layout and color radio buttons to select elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adapt browser_tests to the controls change. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/print_preview.html ('k') | chrome/browser/resources/print_preview/settings/color_settings.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/print_preview.js

diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js

index 6e3bd0e7cfde0d8e667d479b3dbf784b14df4640..3d52bee54ca6b55a7e79abe1b0d4a8ece08cfead 100644

--- a/chrome/browser/resources/print_preview/print_preview.js

+++ b/chrome/browser/resources/print_preview/print_preview.js

@@ -1028,13 +1028,13 @@ cr.define('print_preview', function() {

* @private

setLayoutSettingsForTest_: function(portrait) {

- var element = document.querySelector(portrait ?

- '.layout-settings-portrait-radio' :

- '.layout-settings-landscape-radio');

- if (element.checked)

+ var combobox = document.querySelector('.layout-settings-select');

+ if (combobox.value == 'portrait') {

this.nativeLayer_.previewReadyForTest();

- else

- element.click();

+ } else {

+ combobox.value = 'landscape';

+ this.layoutSettings_.onSelectChange_();

+ }

/**