Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 534993003: Fix bug with invalid "location" field instead of "state" field in some (Closed)

Created:
6 years, 3 months ago by reat
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix bug with invalid "location" field instead of "state" field in some cases of unittests. At the current time it works only because numerical value for Manifest::EXTERNAL_PREF, which is right location value for test extensions, is equal to Extension::EXTERNAL_EXTENSION_UNINSTALLED which needs to validate. BUG= R=aa@chromium.org,yoz@chromium.org Committed: https://crrev.com/65392a071925908e8e406f6419365bbde6275699 Cr-Commit-Position: refs/heads/master@{#293402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/extensions/extension_service_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
reat
6 years, 3 months ago (2014-09-03 09:09:25 UTC) #1
Yoyo Zhou
LGTM, nice catch.
6 years, 3 months ago (2014-09-04 20:56:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reat@yandex-team.ru/534993003/1
6 years, 3 months ago (2014-09-04 20:58:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 76100ead0f7d36061fe9c31c5053390d835aed0d
6 years, 3 months ago (2014-09-05 02:14:07 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:35:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65392a071925908e8e406f6419365bbde6275699
Cr-Commit-Position: refs/heads/master@{#293402}

Powered by Google App Engine
This is Rietveld 408576698