Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 534993003: Fix bug with invalid "location" field instead of "state" field in some (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index d0c9564dc90405456ec0501ad85858ae95adadac..efa301b2c899e64aa7b378d62f12777ce5ab87ec 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -894,7 +894,7 @@ class ExtensionServiceTest : public extensions::ExtensionServiceTestBase,
// Verify uninstalled state.
size_t new_pref_key_count = GetPrefKeyCount();
if (new_pref_key_count == pref_key_count) {
- ValidateIntegerPref(id, "location",
+ ValidateIntegerPref(id, "state",
Extension::EXTERNAL_EXTENSION_UNINSTALLED);
} else {
EXPECT_EQ(new_pref_key_count, pref_key_count - 1);
@@ -1555,7 +1555,7 @@ TEST_F(ExtensionServiceTest, UninstallingExternalExtensions) {
// Uninstall it and check that its killbit gets set.
UninstallExtension(good_crx, false);
- ValidateIntegerPref(good_crx, "location",
+ ValidateIntegerPref(good_crx, "state",
Extension::EXTERNAL_EXTENSION_UNINSTALLED);
// Try to re-install it externally. This should fail because of the killbit.
@@ -1567,7 +1567,7 @@ TEST_F(ExtensionServiceTest, UninstallingExternalExtensions) {
false);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(NULL == service()->GetExtensionById(good_crx, false));
- ValidateIntegerPref(good_crx, "location",
+ ValidateIntegerPref(good_crx, "state",
Extension::EXTERNAL_EXTENSION_UNINSTALLED);
version = Version("1.0.0.1");
@@ -1581,7 +1581,7 @@ TEST_F(ExtensionServiceTest, UninstallingExternalExtensions) {
false);
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(NULL == service()->GetExtensionById(good_crx, false));
- ValidateIntegerPref(good_crx, "location",
+ ValidateIntegerPref(good_crx, "state",
Extension::EXTERNAL_EXTENSION_UNINSTALLED);
// Try adding the same extension from an external update URL.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698