mojo/services/view_manager/window_manager_access_policy.h - Issue 534843002: Convert view manager to surfaces with uploading shim in client lib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/window_manager_access_policy.h

Issue 534843002: Convert view manager to surfaces with uploading shim in client lib (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove overzealous shutdown check in cc/surfaces, add NON_EXPORTED_BASE for windows build, saturate… Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/view_manager/view_manager_service_impl.cc ('k') | mojo/services/view_manager/window_manager_access_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/view_manager/window_manager_access_policy.h

diff --git a/mojo/services/view_manager/window_manager_access_policy.h b/mojo/services/view_manager/window_manager_access_policy.h

index 90813adb2277656cf768e679166c790518a1ae84..5730a18b96bb1ed5fc9fcf362b3845220ec0c7b7 100644

--- a/mojo/services/view_manager/window_manager_access_policy.h

+++ b/mojo/services/view_manager/window_manager_access_policy.h

@@ -32,7 +32,7 @@ class WindowManagerAccessPolicy : public AccessPolicy {

const ServerView* view) const OVERRIDE;

virtual bool CanEmbed(const ServerView* view) const OVERRIDE;

virtual bool CanChangeViewVisibility(const ServerView* view) const OVERRIDE;

- virtual bool CanSetViewContents(const ServerView* view) const OVERRIDE;

+ virtual bool CanSetViewSurfaceId(const ServerView* view) const OVERRIDE;

virtual bool CanSetViewBounds(const ServerView* view) const OVERRIDE;

virtual bool ShouldNotifyOnHierarchyChange(

const ServerView* view,