Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: mojo/services/view_manager/view_manager_service_impl.cc

Issue 534843002: Convert view manager to surfaces with uploading shim in client lib (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove overzealous shutdown check in cc/surfaces, add NON_EXPORTED_BASE for windows build, saturate… Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/view_manager_service_impl.cc
diff --git a/mojo/services/view_manager/view_manager_service_impl.cc b/mojo/services/view_manager/view_manager_service_impl.cc
index 4fece9021ddcb1861be2d12ea6b5eef0a54a3e3b..ad0df796dfdc824cc7bb4048f1610376d597517a 100644
--- a/mojo/services/view_manager/view_manager_service_impl.cc
+++ b/mojo/services/view_manager/view_manager_service_impl.cc
@@ -7,13 +7,11 @@
#include "base/bind.h"
#include "mojo/services/public/cpp/geometry/geometry_type_converters.h"
#include "mojo/services/public/cpp/input_events/input_events_type_converters.h"
+#include "mojo/services/public/cpp/surfaces/surfaces_type_converters.h"
#include "mojo/services/view_manager/connection_manager.h"
#include "mojo/services/view_manager/default_access_policy.h"
#include "mojo/services/view_manager/server_view.h"
#include "mojo/services/view_manager/window_manager_access_policy.h"
-#include "third_party/skia/include/core/SkBitmap.h"
-#include "ui/aura/window.h"
-#include "ui/gfx/codec/png_codec.h"
namespace mojo {
namespace service {
@@ -430,28 +428,17 @@ void ViewManagerServiceImpl::GetViewTree(
callback.Run(ViewsToViewDatas(views));
}
-void ViewManagerServiceImpl::SetViewContents(
+void ViewManagerServiceImpl::SetViewSurfaceId(
Id view_id,
- ScopedSharedBufferHandle buffer,
- uint32_t buffer_size,
+ SurfaceIdPtr surface_id,
const Callback<void(bool)>& callback) {
- // TODO(sky): add coverage of not being able to set for random view.
+ // TODO(sky): add coverage of not being able to set for random node.
ServerView* view = GetView(ViewIdFromTransportId(view_id));
- if (!view || !access_policy_->CanSetViewContents(view)) {
+ if (!view || !access_policy_->CanSetViewSurfaceId(view)) {
callback.Run(false);
return;
}
- void* handle_data;
- if (MapBuffer(buffer.get(), 0, buffer_size, &handle_data,
- MOJO_MAP_BUFFER_FLAG_NONE) != MOJO_RESULT_OK) {
- callback.Run(false);
- return;
- }
- SkBitmap bitmap;
- gfx::PNGCodec::Decode(static_cast<const unsigned char*>(handle_data),
- buffer_size, &bitmap);
- view->SetBitmap(bitmap);
- UnmapBuffer(handle_data);
+ view->SetSurfaceId(surface_id.To<cc::SurfaceId>());
callback.Run(true);
}
« no previous file with comments | « mojo/services/view_manager/view_manager_service_impl.h ('k') | mojo/services/view_manager/window_manager_access_policy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698